gnrc_nib: Initial import of a general information base for GNRC#5293
gnrc_nib: Initial import of a general information base for GNRC#5293miri64 wants to merge 7 commits into
Conversation
Amend precondition documentation [ci skip]
|
Can you give a little more information, about the purpose of this module? E.g. how many instances of |
|
It's not much bigger than a neighbor cache entry (or probably smaller due to the |
|
Wow, haven't realized how huge the neighbor cache entries are. Thanks for the explanation anyway. |
| gnrc_ipv6_netif_t *iface; /**< the interface associated with this | ||
| * information */ | ||
| ipv6_addr_t *prefix; /**< prefix or destination */ | ||
| ipv6_addr_t *next_hop; /**< next hop to the destination */ |
There was a problem hiding this comment.
Where are the actual IPv6 addresses stored?
There was a problem hiding this comment.
In some central array, to avoid duplicate addresses.
There was a problem hiding this comment.
How about using universal_address_ts [1] for prefix and next_hop?
Using this container allows for sharing the stored address with the FIB and other modules.
However, it requires to use the provided functions for thread safety, and creating a new container with an address requires to iterate/search the current container entries.
[1] https://github.com/RIOT-OS/RIOT/blob/master/sys/include/universal_address.h#L63
There was a problem hiding this comment.
To be honest I would like to merge the NIB and the FIB in the long term, since they are basically doing the same thing (except that the FIB is providing source routing too and the NIB in addition is containing link-layer and prefix list information). Since your FIB however had proven to be more of a GNRC thing (since other stack implementations come with their own FIB in most cases), I'm not sure if the universality universal_address_t is providing isn't too much overkill
|
This is a new feature and is waiting for other PR, so I think it won't make it for this release... postponing... |
|
Considering #5704, I'm not sure I will continue the work on this PR the way I intended to, so I close it for now. |
Next step on the route to a new NDP.
Depends on #5269.