Skip to content

pkg: remove microcoap#6100

Closed
kaspar030 wants to merge 2 commits into
RIOT-OS:masterfrom
kaspar030:remove_microcoap
Closed

pkg: remove microcoap#6100
kaspar030 wants to merge 2 commits into
RIOT-OS:masterfrom
kaspar030:remove_microcoap

Conversation

@kaspar030
Copy link
Copy Markdown
Contributor

See #6038 for discussion.

@kaspar030 kaspar030 added Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation Area: pkg Area: External package ports Discussion: RFC The issue/PR is used as a discussion starting point about the item of the issue/PR labels Nov 10, 2016
@smlng
Copy link
Copy Markdown
Member

smlng commented Nov 10, 2016

Do we really want to kickout the microcoap package right now? I agree to remove the example and purge the docs.

I personally have some RIOT applications that still depend on microcoap as a RIOT package - though, I will port them to use gcoap as soon as I have time for it.

@OlegHahm
Copy link
Copy Markdown
Member

NAK

👍 for removing the example, but I see no reason to remove the package. And I agree with @smlng that it would definitely break existing applications.

@aabadie
Copy link
Copy Markdown
Contributor

aabadie commented Nov 10, 2016

Instead of immediately remove the microcoap pkg from RIOT, one can propose a smooth alternative : raise a kind of Deprecation Warning explaining that this is package will be removed in the next release (2017.01 ?) of RIOT and that CoAP based application developers should use nanocoap instead.

@kaspar030
Copy link
Copy Markdown
Contributor Author

+1 for keeping the package, I've updated the PR accordingly.

@smlng
Copy link
Copy Markdown
Member

smlng commented Nov 10, 2016

I would keep this PR open/unmerged for a little longer, just to give others the chance to comment.

Nevertheless, from my side: ACK.

@kaspar030
Copy link
Copy Markdown
Contributor Author

I would keep this PR open/unmerged for a little longer, just to give others the chance to comment.

👍, there's no rush at all.

@OlegHahm
Copy link
Copy Markdown
Member

One problem that I see for now: if we remove the example, but not the package our CI won't complain if the package is broken.

@smlng
Copy link
Copy Markdown
Member

smlng commented Nov 10, 2016

So we need to add a small test, to check this; but not a full example?

@kaspar030
Copy link
Copy Markdown
Contributor Author

So we need to add a small test, to check this; but not a full example?

How about we just move the example to tests/ ?

@aabadie
Copy link
Copy Markdown
Contributor

aabadie commented Nov 18, 2016

before moving/removing this example, I would wait for the nanocoap example to be fully documented ;) A README.md file is still missing there.

@kaspar030
Copy link
Copy Markdown
Contributor Author

kaspar030 commented Nov 18, 2016 via email

@haukepetersen
Copy link
Copy Markdown
Contributor

how do we proceed with this PR? Do we still want to remove the microcoap example as we have the gcoap example for now?

@smlng
Copy link
Copy Markdown
Member

smlng commented May 19, 2017

I'm very much in favor of removing the example from the RIOT repository. For one to encourage usage of gcoap (which has already more functionality than microcoap), but -secondly- to cleanup the code we ship a little bit.

However, I also think we shouldn't throw away good code examples - so maybe we could rather move the example to another repository!? We already have the applications repo, but we might also create a distinct examples repo for such things like deprecated or not that simple anymore examples. So we keep the code directly available - not only somewhere in the GIT history of RIOT.

Btw. as already pointed out: we should have a small test app, maybe just compiling the package, like we have for libcoap, for instance.

@kaspar030
Copy link
Copy Markdown
Contributor Author

Closed in favour of #7599.

@kaspar030 kaspar030 closed this Oct 10, 2017
@kaspar030 kaspar030 deleted the remove_microcoap branch October 10, 2017 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: pkg Area: External package ports Discussion: RFC The issue/PR is used as a discussion starting point about the item of the issue/PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants