pkg: remove microcoap#6100
Conversation
91dcd3b to
1644526
Compare
|
Do we really want to kickout the microcoap package right now? I agree to remove the example and purge the docs. I personally have some RIOT applications that still depend on microcoap as a RIOT package - though, I will port them to use gcoap as soon as I have time for it. |
|
NAK 👍 for removing the example, but I see no reason to remove the package. And I agree with @smlng that it would definitely break existing applications. |
|
Instead of immediately remove the microcoap pkg from RIOT, one can propose a smooth alternative : raise a kind of Deprecation Warning explaining that this is package will be removed in the next release (2017.01 ?) of RIOT and that CoAP based application developers should use nanocoap instead. |
1644526 to
559342c
Compare
|
+1 for keeping the package, I've updated the PR accordingly. |
|
I would keep this PR open/unmerged for a little longer, just to give others the chance to comment. Nevertheless, from my side: ACK. |
👍, there's no rush at all. |
|
One problem that I see for now: if we remove the example, but not the package our CI won't complain if the package is broken. |
|
So we need to add a small test, to check this; but not a full example? |
How about we just move the example to tests/ ? |
|
before moving/removing this example, I would wait for the nanocoap example to be fully documented ;) A README.md file is still missing there. |
|
A README.md file is still missing there.
Now that you've gained some experience with nanocoap, you could
volunteer to write one!
|
|
how do we proceed with this PR? Do we still want to remove the microcoap example as we have the |
|
I'm very much in favor of removing the example from the RIOT repository. For one to encourage usage of gcoap (which has already more functionality than microcoap), but -secondly- to cleanup the code we ship a little bit. However, I also think we shouldn't throw away good code examples - so maybe we could rather move the example to another repository!? We already have the applications repo, but we might also create a distinct examples repo for such things like deprecated or not that simple anymore examples. So we keep the code directly available - not only somewhere in the GIT history of RIOT. Btw. as already pointed out: we should have a small test app, maybe just compiling the package, like we have for libcoap, for instance. |
|
Closed in favour of #7599. |
See #6038 for discussion.