Several minor lastminute fixes#21
Merged
cgundogan merged 8 commits intoRIOT-OS:masterfrom Oct 21, 2016
Merged
Conversation
cgundogan
reviewed
Oct 21, 2016
| out interests for a specific name | ||
| * Create some content for /dagstuhl/m2m/<youraccountname> | ||
| * Send an interest for /dagstuhl/m2m/<otheraccountname> | ||
| * Create some content for /monami/m2m/<youraccountname> |
Member
There was a problem hiding this comment.
I would keep this first name component independent of the current conference/event. Otherwise, the next one will change it again from monami to something else.
Member
|
please address my comment, then I ACK |
PeterKietzmann
force-pushed
the
lastmin_fixes
branch
2 times, most recently
from
a61e613 to
35ac272
Compare
PeterKietzmann
force-pushed
the
lastmin_fixes
branch
from
35ac272 to
890cb03
Compare
Member
Author
|
Did that. Squash or not? |
Member
not it's okay this way. ACK and GO |
Member
Author
|
Gracias |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@cgundogan what do you think, shall I squash all commits to one even if each contains a single "fix"?