Skip to content

Added missing modules to README.md.#31

Merged
miri64 merged 1 commit intoRIOT-OS:masterfrom
bernardobelchior:patch-1
Sep 4, 2017
Merged

Added missing modules to README.md.#31
miri64 merged 1 commit intoRIOT-OS:masterfrom
bernardobelchior:patch-1

Conversation

@bernardobelchior
Copy link
Copy Markdown
Contributor

Good Morning,

I had a problem following this task since the README just tells you to include USEMODULE += gnrc_sock_udp, while you are required to add the gnrc_ipv6_default and gnrc_icmpv6_echo.
This took me hours to debug, thinking I had done something wrong.
The Makefile is correct, but I was only following the README (because I wanted to do it by myself) and I think more people may have the same mentality.
Knowing this, I propose to add the new modules (compared to Task 05) to the README.md so the next people following this tutorial don't make the same mistake.

Thank you for your time,
Bernardo Belchior

@smlng smlng requested a review from miri64 September 4, 2017 10:08
Copy link
Copy Markdown
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@miri64 miri64 merged commit d062564 into RIOT-OS:master Sep 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants