.github/workflows: Check Secrets and update actions for NodeJS 24 Compilance#276
Merged
Conversation
maribu
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution
Similar to what I added in RIOT-OS/RIOT#22085, the
riotdockerworkflows should also check if the Docker Hub credentials are set and if not, they shouldn't try to push images.Before:
After:
While testing this, I noticed a slight warning, that NodeJS 20 based actions will be forced to run on NodeJS 24 by June 2026 and by September 2026, they will be disabled. See: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
Testing
I tested it in my fork's
masterbranch and it works: