toolchain for ESP32 added by gschorcht · Pull Request #45 · RIOT-OS/riotdocker

gschorcht · 2018-07-30T11:23:12Z

I have added the installation of the ESP32 toolchain as required for the ESP32 port of RIOT, PR RIOT-OS/RIOT#9426.

The toolchain is installed in /opt/esp and requires about 181 MB after cleanup. All path variables in the makefiles of the ESP32 port point to this directory.

gschorcht · 2018-09-04T10:58:10Z

Can we proceed with this PR to get murdock working for ESP32? Furthermore, I would like to reference riotdocker as possible toolchain option in the board documentation I'm writing for the ESP32 port.

kaspar030 · 2018-09-04T11:01:58Z

looks ok. just one thing: why is python-serial and the dialout group needed? The container up to now has only be used for building. Flashing and terminal should be executed on the host.

gschorcht · 2018-09-04T11:55:09Z

@kaspar030
Ok I see, the intention of riotdocker was only to build the ELF file and not flash it.

Hm, before RIOT can be flashed, the ELF file has to be converted into a special binary image format using esptool.py which requires python-serial. Flashing is also done with esptool.py. Not having the flashing capability in riotdocker would require that the user has to install esptool.py on the host system.

Since older Linux distributions, e.g. Ubuntu 16.4, not offering it as a package, the user would have to start to install toolchain components. Sure, it's a documentation problem, but it does not seem to be comfortable.

kaspar030 · 2018-09-04T12:50:24Z

Hm, before RIOT can be flashed, the ELF file has to be converted into a special binary image format using esptool.py which requires python-serial. Flashing is also done with esptool.py. Not having the flashing capability in riotdocker would require that the user has to install esptool.py on the host system.

Ok, having the tools in the container won't hurt.

But the dialout group thing I don't quite get - the gid of the dialout group will certainly be container-specific, it won't (necessarily) match the dialout group of the host system. If the intention was that a dialout-owned host serial device can be used by the riotbuild user within the container, it will probably not work. (maybe with ubuntu host, ubuntu docker base image...)

gschorcht · 2018-09-04T14:20:56Z

@kaspar030 Of course you are right. I'm too blinded by Linux, where it's quite common for serial devices to be owned by group dialout.

miri64 · 2018-09-04T15:18:44Z

I think what usually happens with other devices that the user is required to configure this properly on their host system (e.g. using udev and/or by joining whatever group the system assigns to the device).

gschorcht · 2018-09-06T07:41:35Z

@kaspar030 What do we do next? Should I remove the addition of the riotbuild user to the dialout group?

At least for my ESP ports, I've documented that using riotdocker consists of two steps

making the RIOT application in Docker with command make BOARD= ...
flashing the RIOT application on the host computer with command make flash-only BOARD=...

where step 2 requires that the flasher program is installed on the host and how esptool.py has to be installed.

gschorcht · 2018-09-28T17:53:13Z

@kaspar030 I removed adding the user to the group dial.

I also had to change the download procedure for the Xtensa ESP32 Toolchain. I replaced the original Espressif toolchain with a version that I created myself using crosstool-NG. This was necessary because Espressif's original toolchain uses a newlib version that printf for floats does not support.

I know Riotdocker is currently blocked by issue #46. I also went into this problem. I hope PR #47 can be merged soon and we can continue with this PR to get murdock working for ESP32.

cladmi · 2018-10-04T10:55:15Z

Dockerfile

+RUN echo 'Installing ESP32 toolchain' >&2 && \
+    mkdir -p /opt/esp && \
+    cd /opt/esp && \
+    git clone --recursive https://github.com/espressif/esp-idf.git && \


Is there a reason to not update to https://github.com/espressif/esp-idf/releases/tag/v3.1 now that it is released?

@cladmi Yes, the reason is that the ESP32 port is realized for the version that is checkout out in the docker file. The problem is that I couldn't simply use the ESP-IDF as it was, but had to change a lot of files, a number of them only because of compile errors like function prototype warnings, for others I had to make real changes. All the files you can find in https://github.com/gschorcht/RIOT-Xtensa-ESP/tree/esp32/cpu/esp32/vendor/esp-idf are modified to get them working with RIOT.

The version I used is a snapshot of v3.1 branch from July 27th.

I will try to update it later, but for the moment I would prefer to leave it as it currently is to integrate the port into the master. Since my time is currently very limited, I fear that the merge would otherwise delayed further. I spent a lot of time porting RIOT to ESP32 in the last half year and the ESP32 port has been completely tested and works very stably with this version of ESP-IDF.

Thanks for the precision, so yeah there is a reason to stay with is one for the moment.

leandrolanzieri · 2018-10-10T10:14:34Z

The MIPS toolchain is now working. Please rebase

gschorcht · 2018-10-10T14:40:37Z

The MIPS toolchain is now working. Please rebase

@leandrolanzieri Done

jia200x · 2018-10-11T08:38:25Z

I'm testing it against RIOT-OS/RIOT#9426

jia200x · 2018-10-11T11:45:14Z

Toolchain works:

Building application "hello-world" for "esp32-olimex-evb" with MCU "esp32".

"make" -C /data/riotbuild/riotbase/core
"make" -C /data/riotbuild/riotbase/drivers
"make" -C /data/riotbuild/riotbase/drivers/mtd
"make" -C /data/riotbuild/riotbase/drivers/periph_common
"make" -C /data/riotbuild/riotbase/sys
"make" -C /data/riotbuild/riotbase/sys/auto_init
"make" -C /data/riotbuild/riotbase/sys/div
"make" -C /data/riotbuild/riotbase/sys/isrpipe
"make" -C /data/riotbuild/riotbase/sys/log
"make" -C /data/riotbuild/riotbase/sys/luid
"make" -C /data/riotbuild/riotbase/sys/newlib_syscalls_default
"make" -C /data/riotbuild/riotbase/sys/posix/pthread
"make" -C /data/riotbuild/riotbase/sys/ps
"make" -C /data/riotbuild/riotbase/sys/random
"make" -C /data/riotbuild/riotbase/sys/random/tinymt32
"make" -C /data/riotbuild/riotbase/sys/stdio_uart
"make" -C /data/riotbuild/riotbase/sys/timex
"make" -C /data/riotbuild/riotbase/sys/tsrb
"make" -C /data/riotbuild/riotbase/sys/xtimer
"make" -C /data/riotbuild/riotboard/esp32-olimex-evb
"make" -C /data/riotbuild/riotboard/common/esp32
"make" -C /data/riotbuild/riotcpu/esp32
"make" -C /data/riotbuild/riotcpu/esp32/freertos
"make" -C /data/riotbuild/riotcpu/esp32/periph
"make" -C /data/riotbuild/riotcpu/esp32/vendor
"make" -C /data/riotbuild/riotcpu/esp32/vendor/esp-idf
"make" -C /data/riotbuild/riotcpu/esp32/vendor/esp-idf/driver
"make" -C /data/riotbuild/riotcpu/esp32/vendor/esp-idf/esp32
"make" -C /data/riotbuild/riotcpu/esp32/vendor/esp-idf/heap
"make" -C /data/riotbuild/riotcpu/esp32/vendor/esp-idf/soc
"make" -C /data/riotbuild/riotcpu/esp32/vendor/esp-idf/spi_flash
"make" -C /data/riotbuild/riotcpu/esp32/vendor/esp-idf/wpa_supplicant
"make" -C /data/riotbuild/riotcpu/esp32/vendor/xtensa
   text    data     bss     dec     hex filename
  75281    4616    8640   88537   159d9 /data/riotbuild/riotproject/examples/hello-world/bin/esp32-olimex-evb/hello-world.elf

jia200x · 2018-10-11T11:49:42Z

ACK on my side. @kaspar030, @cladmi ?

cladmi · 2018-10-11T15:09:15Z

Question, in the ESP32 PR you updated your a repository to have float printfs working.
RIOT-OS/RIOT#9426 (comment)

Has it been included here ? I did not receive github updates about it, maybe it is just me, but I want to be sure it is included.

gschorcht · 2018-10-11T15:54:12Z

@cladmi Yes

git clone https://github.com/gschorcht/xtensa-esp32-elf.git

is the Xtensa compiler suite I prepared which includes the newlib that supports printf for floats.

MrKevinWeiss · 2018-10-12T07:42:17Z

So @cladmi is there anything else or can we go?

cladmi · 2018-10-12T16:16:41Z

Good for me on my concern. But I did not tested it or the referenced PR so I can't approve.

But this PR still need to receive a reviewed ack before merging.
It is not enforced here for the moment but the RIOT rule still applies.

miri64 · 2018-10-12T16:28:54Z

It is not enforced here for the moment but the RIOT rule still applies.

I activated the according branch protection for this repo's master branch.

cladmi · 2018-10-12T16:54:58Z

@miri64 Thanks

jia200x

ok, comments were addressed and the toolchain is working as expected in Docker.

Tested ACK.

jia200x · 2018-10-15T08:08:06Z

& GO

gschorcht · 2018-10-15T09:21:26Z

@jia200x Thanks

waehlisch requested a review from smlng September 4, 2018 11:00

gschorcht force-pushed the esp32 branch from 06be472 to 4a346e5 Compare September 28, 2018 17:39

gschorcht force-pushed the esp32 branch 2 times, most recently from 0255815 to c5870ca Compare September 28, 2018 18:23

jnohlgard added the enhancement label Oct 4, 2018

cladmi reviewed Oct 4, 2018

View reviewed changes

toolchain for ESP32 added

235809c

gschorcht force-pushed the esp32 branch from c5870ca to 235809c Compare October 10, 2018 14:11

jia200x approved these changes Oct 15, 2018

View reviewed changes

jia200x merged commit 23531bc into RIOT-OS:master Oct 15, 2018

jia200x mentioned this pull request Oct 15, 2018

ESP32 port RIOT-OS/RIOT#9426

Merged

ZetaR60 mentioned this pull request Oct 15, 2018

Update to Ubuntu Bionic #42

Merged

gschorcht deleted the esp32 branch September 4, 2019 18:00

Conversation

gschorcht commented Jul 30, 2018 • edited by cladmi Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gschorcht commented Sep 4, 2018

Uh oh!

kaspar030 commented Sep 4, 2018

Uh oh!

gschorcht commented Sep 4, 2018

Uh oh!

kaspar030 commented Sep 4, 2018

Uh oh!

gschorcht commented Sep 4, 2018

Uh oh!

miri64 commented Sep 4, 2018

Uh oh!

gschorcht commented Sep 6, 2018

Uh oh!

gschorcht commented Sep 28, 2018

Uh oh!

cladmi Oct 4, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gschorcht Oct 4, 2018

Choose a reason for hiding this comment

Uh oh!

cladmi Oct 4, 2018

Choose a reason for hiding this comment

Uh oh!

leandrolanzieri commented Oct 10, 2018

Uh oh!

gschorcht commented Oct 10, 2018

Uh oh!

jia200x commented Oct 11, 2018

Uh oh!

jia200x commented Oct 11, 2018

Uh oh!

jia200x commented Oct 11, 2018

Uh oh!

cladmi commented Oct 11, 2018

Uh oh!

gschorcht commented Oct 11, 2018

Uh oh!

MrKevinWeiss commented Oct 12, 2018

Uh oh!

cladmi commented Oct 12, 2018

Uh oh!

miri64 commented Oct 12, 2018

Uh oh!

cladmi commented Oct 12, 2018

Uh oh!

jia200x left a comment

Choose a reason for hiding this comment

Uh oh!

jia200x commented Oct 15, 2018

Uh oh!

gschorcht commented Oct 15, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

gschorcht commented Jul 30, 2018 •

edited by cladmi

Loading

cladmi Oct 4, 2018 •

edited

Loading