Fix block device mapping issues pointed out by CodeRabbit. Also fix linting issues in yaml files.#204
Conversation
WalkthroughThis update applies whitespace and formatting cleanups across multiple CloudFormation YAML templates, including the removal of trailing spaces, redundant blank lines, and alignment corrections. In addition, a redundant block device mapping is removed from the EC2 VSCode template, consolidating configuration. No functional, logical, or parameter changes are introduced. Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🔭 Outside diff range comments (2)
cft-templates/ec2-linux-docker-mysql.yml (1)
66-88: Minor: incorrect intrinsic-function syntax inRoleName/PolicyName
!Join ['-', [Ref: Namespace, 'ec2-role']]should be!Join ['-', [!Ref Namespace, 'ec2-role']]
(the same applies toPolicyName,InstanceProfileName, etc.).
Without the!Refthe template will be rendered literally and CFN will
receive an invalid name.-RoleName: !Join ['-', [Ref: Namespace, 'ec2-role']] +RoleName: !Join ['-', [!Ref Namespace, 'ec2-role']]cft-templates/ec2-dcv.yml (1)
130-140: Case mismatch: desktop entry points tojupyter.shbut the file created isJupyter.sh
Linux is case-sensitive; the autostart desktop entry will fail to launch JupyterLab. Rename one side to match.-Exec="/home/ec2-user/jupyter.sh" +Exec="/home/ec2-user/Jupyter.sh"or rename the script to lower-case – just keep them identical.
🧹 Nitpick comments (6)
cft-templates/igv.yml (1)
318-321: Reduce consecutive blank linesYAML-lint flags four consecutive blank lines (
too many blank lines (4 > 2)).
Delete the extras to comply:- - - - + +cft-templates/ec2-dcv.yml (1)
229-231: Undefined variable in echo statement
Same pattern as in RStudio:${region}is not declared – should be${instance_region}.-echo "Retrieved region ${region} from metadata service" +echo "Retrieved region ${instance_region} from metadata service"cft-templates/ec2-jupyterLab.yml (2)
28-30: Trailing whitespace violates YAML-lint- - t3.large + - t3.large
172-174: Incorrect variable in region log-echo "Retrieved region ${region} from metadata service" +echo "Retrieved region ${instance_region} from metadata service"cft-templates/ec2-vscode.yml (2)
174-177: Same variable typo as other templates-echo "Retrieved region ${region} from metadata service" +echo "Retrieved region ${instance_region} from metadata service"
201-202: Strip trailing spaces to silence YAML-lint- AvailabilityZone: !Ref AvailabilityZone + AvailabilityZone: !Ref AvailabilityZone
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (10)
cft-templates/Rstudio.yml(9 hunks)cft-templates/ec2-EIP.yml(3 hunks)cft-templates/ec2-dcv.yml(13 hunks)cft-templates/ec2-jupyterLab.yml(7 hunks)cft-templates/ec2-linux-docker-mysql.yml(5 hunks)cft-templates/ec2-linux-docker.yml(5 hunks)cft-templates/ec2-vscode.yml(1 hunks)cft-templates/ec2-winsecure-desktop.yml(12 hunks)cft-templates/igv.yml(16 hunks)rg_deploy_bucket.yml(2 hunks)
🧰 Additional context used
🪛 YAMLlint (1.37.1)
cft-templates/ec2-linux-docker-mysql.yml
[error] 1-1: wrong new line character: expected \n
(new-lines)
cft-templates/igv.yml
[warning] 320-320: too many blank lines (4 > 2)
(empty-lines)
cft-templates/ec2-vscode.yml
[error] 201-201: trailing spaces
(trailing-spaces)
cft-templates/ec2-jupyterLab.yml
[error] 29-29: trailing spaces
(trailing-spaces)
🔇 Additional comments (5)
rg_deploy_bucket.yml (1)
114-116: Whitespace cleanup looks goodTrailing-space removal keeps the template YAML-lint-clean without touching policy semantics.
No further action required.Also applies to: 124-126
cft-templates/ec2-linux-docker.yml (1)
26-27: LGTM – default volume size clarifiedKeeping the default EBS volume size on its own line (no trailing space) is clean and
doesn’t affect semantics.cft-templates/ec2-EIP.yml (1)
32-32: Whitespace tidy-up acknowledgedTrailing-space removal and type-line alignment improve readability; no logic change.
Also applies to: 50-50, 120-120
cft-templates/Rstudio.yml (1)
20-24: Default root volume shrunk to 8 GB – double-check capacity needs
The defaultEBSVolumeSizehas been reduced from the usual 30–32 GB down to 8 GB. RStudio-based AMIs quickly fill the root disk once users start installing R / Python packages or storing notebooks. Before this lands, confirm that 8 GB is really acceptable for your target workloads and patch/upgrade patterns.cft-templates/ec2-winsecure-desktop.yml (1)
60-124: Nothing but whitespace – looks good
Only spacing / indentation changed; no functional impact detected.
1 participant
Fix block device mapping issues pointed out by CodeRabbit. Also fix linting issues in yaml files.
This change is
Summary by CodeRabbit