fix(recordvideo): fix the bug of setting value of is_start;#886
Merged
Conversation
guozhen1997
approved these changes
Mar 16, 2026
andylin-hao
approved these changes
Mar 16, 2026
Signed-off-by: Your Name <you@example.com>
Signed-off-by: WinstonWmj <983289917@qq.com>
9 tasks
pppppppppper
pushed a commit
to pppppppppper/RLinf
that referenced
this pull request
Mar 25, 2026
* fix(recordvideo): fix the bug of setting value of is_start; Signed-off-by: Your Name <you@example.com> * fix(collecteps): fix the bug of setting value of is_start; Signed-off-by: WinstonWmj <983289917@qq.com> --------- Signed-off-by: Your Name <you@example.com> Signed-off-by: WinstonWmj <983289917@qq.com> Co-authored-by: Your Name <you@example.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug's fixing: Add 'is_start.setter' to
class RecordVideo.Description
Without this modification, the second round of rollout will get random
reset_state_ids( for every config: xxxx_grpo_xxxx )since the setter doesn't wokr as expected:
Motivation and Context
someone in wechat group found this bug:

How has this been tested?
print and video log:
before fix:

after fix:

Additional information (optional, e.g., figures and logs):
Types of changes
Checklist: