Skip to content

fix(recordvideo): fix the bug of setting value of is_start;#886

Merged
zoeyuchao merged 2 commits into
RLinf:mainfrom
WinstonWmj:bugfix/main
Mar 16, 2026
Merged

fix(recordvideo): fix the bug of setting value of is_start;#886
zoeyuchao merged 2 commits into
RLinf:mainfrom
WinstonWmj:bugfix/main

Conversation

@WinstonWmj
Copy link
Copy Markdown
Collaborator

Bug's fixing: Add 'is_start.setter' to class RecordVideo.

Description

Without this modification, the second round of rollout will get random reset_state_ids ( for every config: xxxx_grpo_xxxx )

since the setter doesn't wokr as expected:

# rlinf/envs/libero/libero_env.py
        if self.is_start:  # the self.is_start is always true without my modification...
            reset_state_ids = (
                self.reset_state_ids if self.use_fixed_reset_state_ids else None
            )
            self._is_start = False

Motivation and Context

someone in wechat group found this bug:
image

How has this been tested?

print and video log:

before fix:
image

after fix:
image

Additional information (optional, e.g., figures and logs):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (Document-only update)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@zoeyuchao zoeyuchao added the run-ci Enable CI tests label Mar 16, 2026
Signed-off-by: Your Name <you@example.com>
Signed-off-by: WinstonWmj <983289917@qq.com>
@zoeyuchao zoeyuchao merged commit 91c7538 into RLinf:main Mar 16, 2026
65 of 67 checks passed
pppppppppper pushed a commit to pppppppppper/RLinf that referenced this pull request Mar 25, 2026
* fix(recordvideo): fix the bug of setting value of is_start;

Signed-off-by: Your Name <you@example.com>

* fix(collecteps): fix the bug of setting value of is_start;

Signed-off-by: WinstonWmj <983289917@qq.com>

---------

Signed-off-by: Your Name <you@example.com>
Signed-off-by: WinstonWmj <983289917@qq.com>
Co-authored-by: Your Name <you@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run-ci Enable CI tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants