Merged
Conversation
foreign key, use stitch.ogsi.models for entities
AlexAxthelm
approved these changes
Mar 6, 2026
| type_adapter: ClassVar[TypeAdapter[OGFieldSource]] = TypeAdapter(OGFieldSource) | ||
|
|
||
| __tablename__ = "oil_gas_field_source" | ||
| __tablename__ = "oil_gas_field_sources" |
Collaborator
There was a problem hiding this comment.
NB: For DB stuff I prefer singular over plural phrasings (old habit dies hard).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove source db model and integrate into
OilGasFieldSourceModel(the new "source" table).membershipsnow have a proper foreign key constraint onog_field_soucesstitch-ogsipydantic models (usage in follow-ups)I opted to keep "Resourced" declared in
stitch-apifor now. I wasn't sure how we want to go for getting the flat/view like version of an "OilGasFieldResource". I see 2 initial options:OGFieldResouceBasetostitch-ogsithat doesn't have theOilGasFieldBasecolumnsOilGasFieldBasecolumns onto the currentresourcestable. then we can usestitch.ogsi.model.OGFieldResourcewithout any other manipulation