feat: rename actions files, split source/resource calls, add utils#36
Merged
AlexAxthelm merged 6 commits intouse-ogsi-modelfrom Mar 6, 2026
Merged
feat: rename actions files, split source/resource calls, add utils#36AlexAxthelm merged 6 commits intouse-ogsi-modelfrom
AlexAxthelm merged 6 commits intouse-ogsi-modelfrom
Conversation
…ource_data in create
fix: address failing python tests
AlexAxthelm
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splits db actions into 2 repository-like files
og_field_resource_actions.py: interface for field resource operationsog_field_source_actions.py: interface for field source operationsAdded
utils.pyto avoid a circular dependency.Meant to add the rest in a separate PR.
Big one is that I opted to drop the "resources" endpoint in favor of "oil-gas-fields". We can revert if anyone loses their mind about it.
We also have the
api/v1/oil-gas-field-sourcesthat's for source-specific calls. Now, I didn't look into it, but I'm sure there's a way we can have a more genericsourcessubpath under/behindoil-gas-fields. So it might look like:oil-gas-fields/sources- all sources (POST & GET)oil-gas-fields/{id}/sources- all sources for id (POST for attach? & GET)This would present a repeatable pattern of
<resource type>/[{id}]/sources/...,<resource type>/merge,<resource type>/unmerge, etc... Food for thought 🤷