fix(docker): remove hardcoded python3.10 paths in OOT stage#1123
Merged
Conversation
The OOT stage had 7 occurrences of hardcoded
`/opt/venv/lib/python3.10/site-packages/` paths, which break when
building with py3.12 base images.
- LD_LIBRARY_PATH: replace hardcoded ENV with dynamic torch lib
detection via ldconfig
- triton backup/restore: use `sysconfig.get_path('purelib')` to
resolve site-packages at build time
Contributor
Author
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the atom_oot Docker build stage to avoid hardcoded Python 3.10 site-packages paths, improving compatibility with newer base images (e.g., Python 3.12) while preserving the existing Triton backup/restore behavior.
Changes:
- Replaces the hardcoded
LD_LIBRARY_PATHtorch lib entry with a dynamically generated/etc/ld.so.conf.d/torch.conf+ldconfig. - Resolves
site-packagesdynamically viasysconfig.get_path('purelib')for Triton backup/restore paths.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
valarLip
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OOT stage had 7 occurrences of hardcoded
/opt/venv/lib/python3.10/site-packages/paths, which break when building with py3.12 base images.sysconfig.get_path('purelib')to resolve site-packages at build timeMotivation
Technical Details
Test Plan
Test Result
Submission Checklist