[MLIR] enhance get_scalar op, only requires dyn_leaf_cnt = 1#398
Merged
[MLIR] enhance get_scalar op, only requires dyn_leaf_cnt = 1#398
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Enhances Fly dialect get_scalar handling so it can accept nested singleton IntTuple shapes (e.g. ((((42)))) / ((((?))))) rather than requiring the tuple attr to be a direct leaf, and adds coverage in the layout-lowering MLIR tests.
Changes:
- Update
GetScalarOpreturn type inference to unwrap rank-1 nesting until a leaf is reached. - Update
fly-layout-lowering’sGetScalarOprewrite to perform the same unwrapping. - Add MLIR tests for nested singleton static and dynamic
get_scalar.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
tests/mlir/Transforms/layout_lowering.mlir |
Adds FileCheck tests validating nested singleton get_scalar is eliminated to constants/SSA values. |
lib/Dialect/Fly/Transforms/LayoutLowering.cpp |
Adjusts GetScalarOp lowering to unwrap nested singleton tuples before extracting the leaf. |
lib/Dialect/Fly/IR/FlyOps.cpp |
Adjusts GetScalarOp type inference to accept nested singleton tuples and improve the diagnostic for non-scalars. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Technical Details
Test Plan
Test Result
Submission Checklist