Tracking changes requested in merged PR #307

[alexandraBara]

@atamazov I will address changes requested here: #307 in an upcoming PR as we want to unblock this PR: #533

also to address:

Find IsCacheDisabled() in binary_cache.cpp
Rename it to IsBinaryCacheDisabled()
Make it global (remove static and add its declaration to binary_cache.hpp)
Use it here instead of MIOPEN_ENABLE_SQLITE_KERN_CACHE

TODO: src/ocl/convolutionocl.cpp perf_db.emoty() check needs to be:

perf_db.emty() and device_cu/compile_only etc not set --> throw error
Otherwise we are still seeing "..incorrect params" thrown from here bc Invokers dont populate the perf_db during compile_only

[atamazov]

@alexandraBara Direct links to relevant items (TODO list):

• Fix for distinct compile/evaluate  #533 (comment)
• Fix for distinct compile/evaluate  #533 (comment)
• leftovers of GPU'less compile  #307 (review)
• 🔴 🐛 Fix for distinct compile/evaluate  #533 (review)
• Important addition to what also needs to be done: No GPU backend for Tuna  #681 (comment)

[atamazov]

@alexandraBara Any progress?

[alexandraBara]

@alexandraBara Any progress?

@atamazov I have been tuning and I am about to finish with it. I picked up this task today and started working on it. Should have a PR this week.

[atamazov]

@alexandraBara Good, thank you!

[daniellowell]

@alexandraBara @atamazov Is this urgency_blocker ticket ready to close?

[atamazov]

@daniellowell I don't think so.

[atamazov]

The TODO list at #560 (comment) is updated. Note that there is one bug that presumably affects auto-tuning, not fixed for long.

[DrizztDoUrden]

About auto-tuning: lines like MIOPEN_FIND_ENFORCE=SEARCH_DB_UPDATE bin/MIOpenDriver conv -x 1 -y 1 fail horribly unless one adds MIOPEN_COMPILE_PARALLEL_LEVEL=1.

[DrizztDoUrden]

@daniellowell I guess that's worth investigation and if I understood correctly, @atamazov has found the PR which caused it: #533 (comment)