[Issue]: accepted options for --cxx-compiler are too narrow

[IMbackK]

Problem Description

Since ROCm/rocBLAS@e884992 rocblas will pass its CMAKE_CXX_COMPILER to tensile via --cxx-compiler unfortionatly tensile is way to strict with this, causing issues. building rocblas -DCMAKE_CXX_COMPILER=/opt/rocm/bin/amdclang++ is perfectly valid, however tensile will not accept this bailing with:

TensileCreateLibrary: error: argument --cxx-compiler: invalid choice: '/opt/rocm/bin/amdclang++' (choose from amdclang++, hipcc)

This is due to

Tensile/Tensile/Tensile.py

Line 131 in a164ed7

choices=[ToolchainDefaults.CXX_COMPILER, "hipcc"],

please remove the choices array here. If desired you can instead check that the path to the given compiler ends with hipcc or amdclang++ but really imo this should only be a warning or something the user can override anyways since there is no reason tensile objects could not be compiled with upstream llvm too. There might also be distro specific reasons for the compiler binary to be renamed.

Operating System

arch

CPU

Any Build issue

GPU

Any Build issue

ROCm Version

Tensile at 80dd256 rocblas at 2ba9a12d62d3de877c75cbd8dff73c50d54b6a98

[bstefanuk]

Hi @IMbackK thanks for raising this issue, I am working to post a patch for this shortly.

[bstefanuk]

See PR #2116. Please note that this restriction has already been loosened for TensileCreateLibrary in the tip of develop.

Just trying to clarify your need @IMbackK. I see you're running on 80dd256, I'm curious, is there a reason you're working off this commit in particular? I can also loosen this restriction on the next patch release for Tensile, if you're willing to wait, otherwise the tip of develop will allow the behaviour you're looking for, after #2116.

[IMbackK]

@bstefanuk 80dd256 was simply the newest commit of tesile the then current newest git of rocblas could be compiled against due to the version check. There was no other reason. You can close this issue once #2116 is merged.