Skip to content

[Fix] permute fusion number of forward output and backward input is not match#160

Closed
RuibinCheung wants to merge 1 commit into
ROCm:devfrom
RuibinCheung:fix_permute
Closed

[Fix] permute fusion number of forward output and backward input is not match#160
RuibinCheung wants to merge 1 commit into
ROCm:devfrom
RuibinCheung:fix_permute

Conversation

@RuibinCheung
Copy link
Copy Markdown
Contributor

Description

Fix permute fusion number of forward output and backward input is not match when inp.numel() is zero.

This is a nvidia's upstream code bug. And it was fixed on PR NVIDIA/TransformerEngine#1468. But this PR involves a feature which relates to PTX. It can't cherry-pick it directly now.

Fixes # (issue)

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refractor

Changes

Please list the changes introduced in this PR:

  • Change A
  • Change B

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants