[Fix] permute fusion number of forward output and backward input is not match#161
Merged
Conversation
217f3bf to
52d03cf
Compare
Contributor
Author
|
@wangye805 PTAL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix permute fusion number of forward output and backward input is not match when inp.numel() is zero.
This is a nvidia's upstream code bug. And it was fixed on PR NVIDIA/TransformerEngine#1468. But this PR involves a feature which relates to PTX. It can't cherry-pick it directly now.
It will return two tensor when expert of MoE dispatched token is 0 but backward function only accepts one tensor. It will raise a runtime error because the number of parameters and arguments is not matched.
Type of change
Changes
Please list the changes introduced in this PR:
Checklist: