Skip to content

Userbuffer epic #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alextmagro merged 18 commits into from
Mar 31, 2026
Merged

Userbuffer epic #367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
d954c6d
Typo fix (#397)
Micky774 Dec 6, 2025
7b5cf20
ROCm UserBuffers for Comm Overlap
alextmagro Oct 30, 2025
640f7e8
Copyrights and cleanup
alextmagro Jan 27, 2026
82faeec
test guards
alextmagro Feb 24, 2026
b6a3ae4
Cleanup and RS flag race condition fix
alextmagro Mar 2, 2026
9e32d3a
Debugging midpoint
alextmagro Mar 12, 2026
84209ad
Cleanup and workspace fix
alextmagro Mar 17, 2026
c669bd2
Guard layer registration in UB
alextmagro Mar 17, 2026
8040909
Cleanup of profiling example for rocm
alextmagro Mar 17, 2026
e375923
Readd example script and update custom_map
alextmagro Mar 17, 2026
c6bd974
fix typo
alextmagro Mar 17, 2026
d76aa06
MI300 test skips due to jittery results
alextmagro Mar 18, 2026
ae979d0
Comment regarding sm_margin performance
alextmagro Mar 18, 2026
b58cbd1
Variable renamed, pybind fix, tolerance tightening
alextmagro Mar 23, 2026
e5d7446
Remove git conflict
alextmagro Mar 24, 2026
7734ce5
Address style and hip/cu specific paths
alextmagro Mar 26, 2026
c169c75
HIP guards
alextmagro Mar 27, 2026
7ddb539
Update extensions.h
alextmagro Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions build_tools/hipify/custom_map.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,21 @@
"CUfunc_cache" : "hipFuncCache_t",
"<nvtx3/nvToolsExt.h>" : "<roctracer/roctx.h>",
"cudaFuncSetAttribute(" : "hipFuncSetAttribute((const void*)",
"__nv_bfloat162":"__hip_bfloat162",
"__nv_fp8_e5m2" : "te_hip_fp8_e5m2",
"__nv_fp8_e4m3" : "te_hip_fp8_e4m3",
"cuda::getCurrentCUDAStream" : "hip::getCurrentHIPStreamMasqueradingAsCUDA",
"__nv_fp4_e2m1" : "__hip_fp4_e2m1",
"__nv_fp4x2_e2m1" : "__hip_fp4x2_e2m1",
"__nv_fp4x4_e2m1" : "__hip_fp4x4_e2m1",
"__nv_fp4x2_storage_t" : "__hip_fp4x2_storage_t",
"#include <cudaTypedefs.h>" : "",
"#include <cuda/barrier>" : ""
"#include <cuda/barrier>" : "",
"cudaLaunchKernelExC": "hipLaunchKernelExC",
"CUmemGenericAllocationHandle": "hipMemGenericAllocationHandle_t",
"cudaLaunchConfig_t": "hipLaunchConfig_t",
"cudaLaunchAttribute": "hipLaunchAttribute",
"cudaLaunchAttributeCooperative": "hipLaunchAttributeCooperative",
"CUdeviceptr": "hipDeviceptr_t"
}
}

5 changes: 2 additions & 3 deletions build_tools/pytorch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,12 +102,11 @@ def setup_pytorch_extension(
cxx_flags.append("-DNVTE_ENABLE_NVSHMEM")

if bool(int(os.getenv("NVTE_ENABLE_ROCSHMEM", 0))):
cxx_flags.append("-DNVTE_ENABLE_ROCSHMEM")
mpi_home = Path(os.getenv("MPI_HOME", "/usr/lib/x86_64-linux-gnu/openmpi"))
include_dirs.append(mpi_home / "include")
library_dirs.append(mpi_home / "lib")
libraries.append("mpi_cxx")

libraries.append("mpi")
cxx_flags.extend(["-DNVTE_ENABLE_ROCSHMEM", "-DOMPI_SKIP_MPICXX"])

# Construct PyTorch CUDA extension
sources = [str(path) for path in sources]
Expand Down
1 change: 1 addition & 0 deletions ci/pytorch.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ run_test_config_mgpu(){
run_default_fa 1 test_gemm_sm_count.py
run_default_fa 3 test_sanity_import.py
run_default_fa 3 distributed/test_cast_master_weights_to_fp8.py
run_default_fa 3 distributed/test_comm_gemm_overlap.py
run_default_fa 2 distributed/test_fusible_ops.py
run_default_fa 2 distributed/test_numerics.py
run_default_fa 1 distributed/test_torch_fsdp2.py
Expand Down
Loading
Loading