refactor hip kernel -- remove torch from csrc#2545
Merged
Conversation
Contributor
🏷️ CI GuideRuns automatically on every PR:
Extended tests (opt-in via labels):
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the C++/HIP side tensor handling to reduce reliance on Torch-side allocations by introducing a small RAII GPU tensor wrapper and adjusting header include ordering so the wrapper can use existing HIP error-handling macros.
Changes:
- Added
AiterTensor(move-only RAII) to allocate/free HIP device memory and provideempty/empty_like/zerosfactory methods. - Updated header includes so
aiter_tensor.hcan useHIP_CALL, andaiter_hip_common.hpulls in tensor definitions after macros are defined.
Reviewed changes
Copilot reviewed 1 out of 1 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| csrc/include/aiter_tensor.h | Adds AiterTensor RAII wrapper and switches header dependencies to HIP common utilities. |
| csrc/include/aiter_hip_common.h | Reorders inclusion of aiter_tensor.h to ensure HIP_CALL is available to AiterTensor. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
amd-ruitang3
force-pushed
the
refactor_hip_kernel
branch
from
dd42050 to
83a29f7
Compare
valarLip
approved these changes
Apr 6, 2026
yzhou103
pushed a commit
that referenced
this pull request
Apr 8, 2026
* refactor hip kernel -- remove torch from csrc * update * hide stream in api * update * update * update * update * update * update * update * update * update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Technical Details
Test Plan
Test Result
Submission Checklist