Skip to content

[TRITON] Reduce rope tests#2588

Merged
vgokhale merged 2 commits intomainfrom
vinayak/reduce_aiter_rope_uts
Apr 3, 2026
Merged

[TRITON] Reduce rope tests#2588
vgokhale merged 2 commits intomainfrom
vinayak/reduce_aiter_rope_uts

Conversation

@vgokhale
Copy link
Copy Markdown
Contributor

@vgokhale vgokhale commented Apr 2, 2026

Rope had 138757 UTs. We don't need that many. Reduced to 1987.

@vgokhale vgokhale requested review from a team and k50112113 April 2, 2026 01:53
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2026

🏷️ CI Guide

Runs automatically on every PR:

  • ✅ Pre-checks (submodule verification, code formatting)
  • ✅ Aiter op tests (gfx942 + gfx950)
  • ✅ Triton tests (only when aiter/ops/triton/** or related paths are changed)

Extended tests (opt-in via labels):

Label Tests
ci:triton-355 Run Triton tests on MI355 in addition to MI325
ci:sglang SGLang integration tests
ci:atom ATOM benchmark (DeepSeek-R1 + GPT-OSS)
ci:vllm vLLM benchmark
ci:all All of the above

Add labels via the sidebar or gh pr edit 2588 --add-label <label>

brunomazzottiamd
brunomazzottiamd previously approved these changes Apr 2, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@brunomazzottiamd brunomazzottiamd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread op_tests/triton_tests/rope/test_fused_qkv_split_qk_rope.py
@gyohuangxin
Copy link
Copy Markdown
Member

gyohuangxin commented Apr 2, 2026

@vgokhale Please fix the code style issue https://github.com/ROCm/aiter/actions/runs/23879861057/job/69630674567?pr=2588

k50112113
k50112113 previously approved these changes Apr 2, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@k50112113 k50112113 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

azaidy
azaidy previously approved these changes Apr 2, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@azaidy azaidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vgokhale vgokhale dismissed stale reviews from azaidy, k50112113, and brunomazzottiamd via d04692b April 3, 2026 01:47
azaidy
azaidy approved these changes Apr 3, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@azaidy azaidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vgokhale vgokhale merged commit 4653a07 into main Apr 3, 2026
33 of 38 checks passed
@vgokhale vgokhale deleted the vinayak/reduce_aiter_rope_uts branch April 3, 2026 13:08
yzhou103 pushed a commit that referenced this pull request Apr 8, 2026
@vgokhale @yzhou103
[TRITON] Reduce rope tests (#2588)
89f67d5 
Rope had 138757 UTs. We don't need that many. Reduced to 1987.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@azaidy azaidy azaidy approved these changes

@brunomazzottiamd brunomazzottiamd Awaiting requested review from brunomazzottiamd

@k50112113 k50112113 Awaiting requested review from k50112113

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vgokhale @gyohuangxin @azaidy @k50112113 @brunomazzottiamd