Conversation
Contributor
🏷️ CI GuideRuns automatically on every PR:
Extended tests (opt-in via labels):
|
e800fb8 to
2bed68a
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the grouped top‑k dispatch logic to avoid using moe_fused_gate for configurations with large experts-per-group (notably affecting GLM5), and adjusts the associated benchmark test to skip the moe_fused_gate comparison in those cases.
Changes:
- Update
biased_grouped_topkdispatch to route to the HIP implementation when experts-per-group exceeds 32. - Gate the
moe_fused_gate(“sglang”) performance/correctness comparison in the benchmark test to only run when experts-per-group is ≤ 32.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| op_tests/test_moeTopkSoftmax.py | Skips moe_fused_gate comparison when experts-per-group exceeds the supported threshold. |
| aiter/ops/topk.py | Adjusts dispatch logic to avoid moe_fused_gate when experts-per-group is too large. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
valarLip
approved these changes
Apr 4, 2026
3 tasks
yzhou103
pushed a commit
that referenced
this pull request
Apr 8, 2026
* Fix group topk dispatch for glm5 * update grouped_topk not compute topk group when group=1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Technical Details
Test Plan
Test Result
Submission Checklist