Merged
Conversation
Contributor
🏷️ CI GuideRuns automatically on every PR:
Extended tests (opt-in via labels):
|
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors parts of the HIP tensor utility layer by improving device correctness around memory ops and updating AiterTensor::empty_like() to preserve the source tensor’s strided layout when allocating storage. It also removes a Python-side HIP stream sync helper previously called during Torch→pybind tensor conversion.
Changes:
- Update
AiterTensor::empty_like()to preserve shape/strides and allocate storage sized for the full positive-stride span. - Add
HipDeviceGuardaround device-sensitive operations (hipMemset*,hipFree) and add a max-dims check ininit_shape(). - Remove
_sync_hip_stream()and its invocation fromtorch_to_aiter_pybind().
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
csrc/include/aiter_tensor.h |
Adjusts allocation semantics for empty_like(), adds device guarding for memset/free, and adds a dims bound check. |
aiter/utility/dtypes.py |
Removes implicit HIP stream synchronization from Torch→pybind tensor conversion. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
junhaha666
approved these changes
Apr 8, 2026
yzhou103
pushed a commit
that referenced
this pull request
Apr 8, 2026
* refactor hip kernel * optimize aiter tensor * update * update * update * update * update * update * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * update --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Technical Details
Test Plan
Test Result
Submission Checklist