Fix release workflow: runner labels, Docker username, setuptools_scm#2702
Merged
gyohuangxin merged 1 commit intoROCm:mainfrom Apr 13, 2026
Merged
Fix release workflow: runner labels, Docker username, setuptools_scm#2702gyohuangxin merged 1 commit intoROCm:mainfrom
gyohuangxin merged 1 commit intoROCm:mainfrom
Conversation
Three independent bugs preventing release builds: 1. Runner labels don't exist: aiter-mi300-1gpu, aiter-mi325-1gpu were never registered. Use aiter-1gpu-runner (MI325 1-GPU, confirmed in aiter-test.yaml). Fix linux-aiter-mi355-1 typo to linux-aiter-mi35x-1. 2. Docker username typo: rocmshard -> rocmshared (missing 'e'), causing Docker login failure on build-only-aiter runner. 3. setuptools_scm 10.x breaks build: moved core to vcs_versioning package, causing ModuleNotFoundError. Pin to <10 until pyproject.toml is updated. Also protect tag-based builds from cancel-in-progress.
Contributor
🏷️ CI GuideRuns automatically on every PR:
Extended tests (opt-in via labels):
|
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes multiple GitHub Actions release-workflow blockers so manual release builds can start promptly, authenticate to Docker, and complete Python wheel builds reliably.
Changes:
- Update workflow_dispatch defaults/options for runner selection and Docker username.
- Prevent tag-based release runs from being cancelled by concurrency settings.
- Add an explicit
setuptools_scmpin step inside the build container to avoid breaking versions.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - linux-aiter-mi355-1 | ||
| - aiter-1gpu-runner | ||
| - build-only-aiter | ||
| - linux-aiter-mi35x-1 |
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: ${{ github.ref != 'refs/heads/main' }} | ||
| cancel-in-progress: ${{ github.ref != 'refs/heads/main' && !startsWith(github.ref, 'refs/tags/v') }} |
| docker exec \ | ||
| -w /workspace \ | ||
| aiter_build_${{ matrix.python_version }} \ | ||
| pip install --timeout=60 --retries=10 "setuptools_scm<10" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three independent bugs preventing release builds from completing:
aiter-mi300-1gpuandaiter-mi325-1gpuwere never registered as GitHub Actions runners. Builds queued indefinitely (7+ hours). Changed default toaiter-1gpu-runner(confirmed working inaiter-test.yaml). Fixedlinux-aiter-mi355-1typo tolinux-aiter-mi35x-1.rocmshard->rocmshared(missing 'e'), causing Docker login failure onbuild-only-aiterrunner.setuptools_scm10.0.5 moved core tovcs_versioningpackage, causingModuleNotFoundError: No module named 'vcs_versioning'. Pin to<10untilpyproject.tomlis updated.Also protects tag-based builds from
cancel-in-progress.Test plan
aiter-1gpu-runnerlabel exists and picks up jobs (run 24287110305 was picked up immediately)rocmsharedis the correct Docker username (used in aiter-test.yaml, triton-test.yaml)setuptools_scm<10(9.2.2) fixes the build (tested in 6 local containers)