[smoke-fort-fails] Add test case for use_device_ptr#2196
Merged
DominikAdamski merged 1 commit intoROCm:aomp-devfrom Apr 27, 2026
Merged
[smoke-fort-fails] Add test case for use_device_ptr#2196DominikAdamski merged 1 commit intoROCm:aomp-devfrom
DominikAdamski merged 1 commit intoROCm:aomp-devfrom
Conversation
Check if use_device_ptr generates the same result as use_device_ptr;
DominikAdamski
requested review from
carlobertolli,
estewart08,
gregrodgers,
ronlieb and
zGoldthorpe
as code owners
mjklemm
approved these changes
Apr 27, 2026
Contributor
mjklemm
left a comment
mjklemm
left a comment
There was a problem hiding this comment.
IK'm fine with the PR.
I need to say though: that this test is about an implementation detail. In an OpenMP sense, the device pointer and the device address need not be the same. They can differ (e.g., for something like OpenCL, where the pointer can be the OpenCL buffer object and the address is the actual pointer on the device).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check if use_device_ptr generates the same result as use_device_ptr clause.