[Flang][OpenMP][fortran-map-tests] Add initialized common block test#2242
Merged
Conversation
agozillon
requested review from
carlobertolli,
estewart08,
gregrodgers,
ronlieb and
zGoldthorpe
as code owners
It turns out initialized common blocks are generated to slightly different LLVM-IR than a zero initialized common block, former is a tuple, latter is a byte array. So good to have a test verifying this also functions and continues to do so.
agozillon
force-pushed
the
amd/dev/agozillo/add-cb-init-test
branch
from
c3b8cb7 to
ae613e4
Compare
dpalermo
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turns out initialized common blocks are generated to slightly different LLVM-IR than a zero initialized common block, former is a tuple, latter is a byte array. So good to have a test verifying this also functions and continues to do so.