Skip to content

CI: Implement automatic pre-commit checks with a GHA workflow#320

Open
leo-amd wants to merge 1 commit intomasterfrom
leo/implement-precommit-checks
Open

CI: Implement automatic pre-commit checks with a GHA workflow#320
leo-amd wants to merge 1 commit intomasterfrom
leo/implement-precommit-checks

Conversation

@leo-amd
Copy link
Copy Markdown
Collaborator

@leo-amd leo-amd commented Mar 18, 2026

hooks:
-   id: trailing-whitespace
-   id: check-ast
-   id: check-json
-   id: check-merge-conflict
-   id: check-toml
-   id: check-yaml

@leo-amd leo-amd requested a review from jithunnair-amd March 19, 2026 15:49
@jithunnair-amd
Copy link
Copy Markdown
Collaborator

Thanks @leo-amd for the PR. Let's merge this PR only after all the pre-commit checks are clean.

@amd-sriram It seems the extra spaces check caught some legit instances: https://github.com/ROCm/apex/actions/runs/23252552729/job/67598289100?pr=320
Can you please fix them in a different PR, so we can rebase this PR and rerun the checks to go to the next set of errors? If you run these pre-commit checks locally, that'd be best.

@jithunnair-amd jithunnair-amd mentioned this pull request Mar 23, 2026
1 task
@amd-sriram amd-sriram mentioned this pull request Mar 27, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants