Check unit test pass/failure and handle timeout error in halo test#323
Draft
amd-sriram wants to merge 2 commits intomasterfrom
Draft
Check unit test pass/failure and handle timeout error in halo test#323amd-sriram wants to merge 2 commits intomasterfrom
amd-sriram wants to merge 2 commits intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Halo test takes more than 10 hours to run - https://github.com/ROCm/apex/actions/runs/23252552706/job/67612063034?pr=320
There is no graceful way to exit in case of timeout
run - https://github.com/ROCm/apex/actions/runs/23505553410/job/68420328568
Technical Details
To check for unit test failure, assert statement similar to nvidia apex is added -
https://github.com/NVIDIA/apex/blob/master/apex/contrib/test/peer_memory/test_peer_halo_exchange_module.py#L134.
The following changes are made to address timeout error:
Test Plan
Run the CI and check how much time the halo test takes with this change.
Test Result
Run - https://github.com/ROCm/apex/actions/runs/23668144565
The halo test takes ... hours.
Submission Checklist