Matrix B skips LDS#264
Closed
ltqin wants to merge 36 commits into
Closed
Conversation
rosenrodt
reviewed
May 31, 2022
|
|
||
| // return block_id to C matrix tile idx (m0, n0) mapping | ||
| __host__ __device__ static constexpr auto | ||
| MakeDefaultBlock2CTileMap(const CGridDesc_M_N& c_grid_desc_m_n, index_t M01, index_t N01) |
Contributor
There was a problem hiding this comment.
This function has been moved to its own classes. Please see PR #235 for reference.
| do | ||
| { | ||
| a_blockwise_copy.RunRead(a_grid_desc_k0_m_k1, a_grid_buf); | ||
| b_threadwise_copy.Run(b_grid_desc_k0_k1_k2_n0_n1_n2_n3_k3, |
Contributor
There was a problem hiding this comment.
I have a feeling that maybe we can configure B BlockwiseCopy in a way that it simply skips loading to LDS. This way maybe we can just reuse the same GridwiseGemmPipeline_v1 and BlockwiseGemm. Is it doable?
rosenrodt
reviewed
May 31, 2022
| __host__ __device__ static constexpr index_t | ||
| CalculateGridSize(const CGridDesc_M_N& c_grid_desc_m_n) | ||
| { | ||
| const auto M = c_grid_desc_m_n.GetLength(I0); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.