[CK TILE ENGINE] Code changes to finding GPU id from TARGET#3055
Merged
ThomasNing merged 5 commits intodevelopfrom Oct 20, 2025
Merged
[CK TILE ENGINE] Code changes to finding GPU id from TARGET#3055ThomasNing merged 5 commits intodevelopfrom
ThomasNing merged 5 commits intodevelopfrom
Conversation
ThruptiRajLakshmanaGowda
requested review from
ThomasNing,
afagaj,
andriy-ca,
aosewski,
aska-0096,
asleepzzz,
bartekxk,
carlushuang,
cgmillette,
coderfeli,
geyyer,
illsilin,
poyenc,
qianfengz,
shumway,
tenpercent and
vidyasagar-amd
as code owners
ThomasNing
reviewed
Oct 20, 2025
| # Get GPU name | ||
| gpu_name = get_gpu_name_by_id(0) | ||
| print(f"Detected GPU: {gpu_name}") | ||
| gpu_name = "gfx90a" |
Contributor
There was a problem hiding this comment.
@ThruptiRajLakshmanaGowda I will merge it now to address the merging issue but let's fix this part after this PR. We need to inherit the gpu_name from the user given input.
Contributor
Author
There was a problem hiding this comment.
This is the test file, so there would be no user given input
ThomasNing
approved these changes
Oct 20, 2025
Jeff-Huang
pushed a commit
that referenced
this pull request
Oct 25, 2025
* Reading gpuname from target for gemm in ck tile engine * Reading gpuname from target for gemm preshuffle in ck tile engine * Reading gpuname from target for gemm preshuffle in ck tile engine * Get GPU changes for GEMM Muti D in TILE ENGINE * Addressing errors for gpu name in cktileengine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Currently in CK TILE ENGINE gpu id is fetched using get_gpu_name_by_id, but this is leading to a build failure with rocm-7.x as reported as an issue (#2994) this PR addresses the issue and we will be able to build locally with rcom-7.x
Checklist
Please put an
xinto the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.clang-formaton all changed filesDiscussion
If this is a relatively large or complex change, feel free to start a discussion by explaining why you chose the solution you did and what alternatives you considered