Conversation
This reverts commit 85a34fd.
|
Well, you're not actually removing any of the gfx macros, you're just replacing the individual ones like gfx942 or gfx950 with a combined one, gfx9, which gets defined when any of the gfx908, gfx90a, gfx942, or gfx950 are defined. So I'm not sure whether these changes will have the desired effect. Have you actually verified them? Are you able to run ckProfiler with tf32 convolutions on any of the gfx9xx devices with these changes? |
Yes. |
|
Convert to draft PR because it is under development now. |
|
Update this PR, remove gfx from CPU code is not final solution which introduces build fail on un-support TF32 platform. |
Proposed changes
CKProfiler files are actually CPU code.
__gfxmacros doesn't work. Remove them and useCK_ENABLE_TF32control whether enroll this datatypes compilation.Checklist
Please put an
xinto the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.clang-formaton all changed filesDiscussion