[CK Tile] Fix FMHA LSE calculation and potential division by zero#3326
Merged
Jeff-Huang merged 1 commit intodevelopfrom Jan 13, 2026
Merged
[CK Tile] Fix FMHA LSE calculation and potential division by zero#3326Jeff-Huang merged 1 commit intodevelopfrom
Jeff-Huang merged 1 commit intodevelopfrom
Conversation
Jeff-Huang
requested review from
ThomasNing,
afagaj,
andriy-ca,
aosewski,
asleepzzz,
bartekxk,
carlushuang,
cgmillette,
coderfeli,
geyyer,
illsilin,
poyenc,
qianfengz,
shumway,
tenpercent and
vidyasagar-amd
as code owners
asleepzzz
reviewed
Nov 28, 2025
| if(l_[i_idx] == 0.0f) | ||
| { | ||
| lse(i_idx) = m_[i_idx] / C_LOG2E + log(l_[i_idx]); | ||
| lse(i_idx) = -numeric<LSEDataType>::infinity(); |
Contributor
There was a problem hiding this comment.
add some comments to explain it
Contributor
Author
There was a problem hiding this comment.
I've added some comments to explain these changes in last update.
Jeff-Huang
force-pushed
the
SWDEV-561757
branch
4 times, most recently
from
e3f1db9 to
7078f52
Compare
This commit addresses numerical stability issues in the BlockFmhaPipelineQRKSVS pipeline when bias has -inf masking values: 1. Explicitly handle the case where the accumulated exponential sum (l) is zero. In this case, the LSE is now correctly set to negative infinity, preventing log(0) errors. 2. Extend the zero-check protection in the normalization step to cover the ELEMENTWISE_BIAS case, preventing potential division by zero.
Jeff-Huang
force-pushed
the
SWDEV-561757
branch
from
7078f52 to
fd1d686
Compare
asleepzzz
approved these changes
Dec 9, 2025
poyenc
approved these changes
Dec 19, 2025
shumway
pushed a commit
that referenced
this pull request
Jan 15, 2026
) This commit addresses numerical stability issues in the BlockFmhaPipelineQRKSVS pipeline when bias has -inf masking values: 1. Explicitly handle the case where the accumulated exponential sum (l) is zero. In this case, the LSE is now correctly set to negative infinity, preventing log(0) errors. 2. Extend the zero-check protection in the normalization step to cover the ELEMENTWISE_BIAS case, preventing potential division by zero.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit addresses numerical stability issues in the BlockFmhaPipelineQRKSVS pipeline when bias has -inf masking values:
Proposed changes
Checklist
Please put an
xinto the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.clang-formaton all changed filesDiscussion
If this is a relatively large or complex change, feel free to start a discussion by explaining why you chose the solution you did and what alternatives you considered