[CK TILE ENGINE] Enable gfx950 GPU architecture for supported combination#3463
Closed
ThruptiRajLakshmanaGowda wants to merge 5 commits intodevelopfrom
Closed
[CK TILE ENGINE] Enable gfx950 GPU architecture for supported combination#3463ThruptiRajLakshmanaGowda wants to merge 5 commits intodevelopfrom
ThruptiRajLakshmanaGowda wants to merge 5 commits intodevelopfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables support for the AMD gfx950 GPU architecture in the CK tile engine GEMM operations. The change removes the previous TODO comment and adds gfx950 to the list of supported GPU targets.
- Added gfx950 to the list of desired GPU targets for GEMM operations
- Added CI pipeline stage for testing TILE_ENGINE_GEMM operations on gfx950 hardware
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tile_engine/ops/gemm_streamk/CMakeLists.txt | Added gfx950 to DESIRED_TARGETS list for GEMM StreamK operations |
| Jenkinsfile | Added new CI stage to run TILE_ENGINE_GEMM tests on gfx950 hardware with various data types and layouts |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ThomasNing
requested changes
Dec 25, 2025
| -D GEMM_DATATYPE="fp8;fp16" \ | ||
| -D GEMM_LAYOUT="rcr" \ | ||
| -D GEMM_STREAMK_DATATYPE="fp8;fp16" \ | ||
| -D GEMM_STREAMK_LAYOUT="rcr" \ |
Contributor
There was a problem hiding this comment.
Need to support for different layouts
Contributor
Author
|
Creating a new one for gfx950 support |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR enables support for the AMD gfx950 GPU architecture in the CK tile engine GEMM operations.
Checklist
Please put an
xinto the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.clang-formaton all changed filesDiscussion
If this is a relatively large or complex change, feel free to start a discussion by explaining why you chose the solution you did and what alternatives you considered