-
Notifications
You must be signed in to change notification settings - Fork 261
Temporarily disable kernel instances that won't build on gfx1101 on Windows #3499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
DarylHawkinsAMD
merged 9 commits into
develop
from
users/dahawkin/navi-windows-miopen-integration
Dec 31, 2025
Merged
Temporarily disable kernel instances that won't build on gfx1101 on Windows #3499
DarylHawkinsAMD
merged 9 commits into
develop
from
users/dahawkin/navi-windows-miopen-integration
Dec 31, 2025
+27
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shumway
previously approved these changes
Dec 30, 2025
Collaborator
|
Can you also guard this so that this is only disabled in Windows? It's breaking Linux tests, and I don't think we want to disable linux kernels. |
Contributor
Author
Done, and added additional info and a TODO |
shumway
previously approved these changes
Dec 30, 2025
bartekxk
previously approved these changes
Dec 30, 2025
shumway
approved these changes
Dec 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This source file won't build for gfx1101 on Windows. It builds successfully on other gfx110X architectures, and also builds successfully on gfx1101 on Linux.
This is the compile error:
This appears to be a compiler bug and we'll follow up to get a proper fix landed, but for the purposes of landing some work to enable gfx1151 support in TheRock we'd like to disable building of these kernels on this architecture temporarily.
Checklist
Please put an
xinto the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.clang-formaton all changed filesDiscussion
If this is a relatively large or complex change, feel free to start a discussion by explaining why you chose the solution you did and what alternatives you considered