[Conv] Enable bwd weight splitk autodeduction with cap#3656
Merged
johannes-graner merged 8 commits intodevelopfrom Jan 29, 2026
Merged
[Conv] Enable bwd weight splitk autodeduction with cap#3656johannes-graner merged 8 commits intodevelopfrom
johannes-graner merged 8 commits intodevelopfrom
Conversation
bartekxk
previously approved these changes
Jan 27, 2026
4feac1e to
55d8e9b
Compare
vpietila-amd
previously approved these changes
Jan 29, 2026
Contributor
vpietila-amd
left a comment
There was a problem hiding this comment.
Looks good to me. One minor comment regarding the WMMA multi-D kernel, but we can fix this separately.
|
|
||
| static bool IsSupportedArgument(const Argument& arg) | ||
| { | ||
| #if DISABLE_SPLIT_K_AUTODEDUCE_FOR_ONE_STAGE_KERNELS |
Contributor
There was a problem hiding this comment.
Can you modify this such that we return false if BlkGemmPipelineVer == BlockGemmPipelineVersion::v4 since the autodeducted split-K value is probably too low in this case.
bartekxk
previously approved these changes
Jan 29, 2026
66d2769
vpietila-amd
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Enables split-k autodeduction for old CK bwd weight convolutions. Since the autodeduction can produce very large split-k values that lead to inaccuracy, the deduced value is capped at 128. Under the assumption that performance is a convex function of split-k and the auto-deduced value is correct, capping at 128 results in the best reasonable value if the reasonable values are
{1, ..., 128}.Enabling autodeduction led to tests using larger split-k values, which exposed a bug in the profiler error threshold calculations. This was also addressed since it made the tests fail.
Checklist
Please put an
xinto the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.clang-formaton all changed filesDiscussion
If this is a relatively large or complex change, feel free to start a discussion by explaining why you chose the solution you did and what alternatives you considered