Skip to content

Conv3D FWD BWD WRW fp16 fp32 client examples#559

Merged
zjing14 merged 19 commits into
developfrom
aosewski/conv3d_example
Feb 15, 2023
Merged

Conv3D FWD BWD WRW fp16 fp32 client examples#559
zjing14 merged 19 commits into
developfrom
aosewski/conv3d_example

Conversation

@aosewski
Copy link
Copy Markdown
Collaborator

@aosewski aosewski commented Jan 19, 2023

No description provided.

@aosewski aosewski requested review from geyyer and zjing14 January 19, 2023 16:52
@aosewski aosewski self-assigned this Jan 19, 2023
geyyer
geyyer requested changes Jan 20, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@geyyer geyyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good overall! Please see the comments.

Comment thread client_example/11_grouped_conv_bwd_weight/grouped_conv3d_bwd_weight_fp16.cpp Outdated
Comment thread client_example/11_grouped_conv_bwd_weight/grouped_conv3d_bwd_weight_fp32.cpp Outdated
Comment thread client_example/16_convnd_fwd/common.hpp Outdated
Comment thread client_example/16_convnd_fwd/conv3d_fwd_fp16.cpp
@geyyer
Copy link
Copy Markdown
Contributor

geyyer commented Jan 20, 2023

@aosewski, the example 16 looks like it is a grouped_conv3d_fwd, would it make sense to rename it?

@aosewski
Copy link
Copy Markdown
Collaborator Author

aosewski commented Jan 23, 2023 •
edited
Loading

@aosewski, the example 16 looks like it is a grouped_conv3d_fwd, would it make sense to rename it?

@geyyer
I named it like that, since it should be very easy to add examples for other dimensions.

@geyyer geyyer self-requested a review January 23, 2023 16:48
geyyer
geyyer previously approved these changes Jan 23, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@geyyer geyyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aosewski
Copy link
Copy Markdown
Collaborator Author

aosewski commented Jan 27, 2023

@zjing14 The PR is ready for your review and merge.

asroy
asroy reviewed Jan 30, 2023
View reviewed changes
Comment thread client_example/11_grouped_conv_bwd_weight/grouped_conv2d_bwd_weight_fp16.cpp
@aosewski aosewski requested a review from asroy February 3, 2023 14:37
@aosewski
Copy link
Copy Markdown
Collaborator Author

aosewski commented Feb 3, 2023

@asroy @zjing14 I've updated example layout to the standard one. I'd be grateful for review.

@zjing14 zjing14 merged commit e9fd122 into develop Feb 15, 2023
@aosewski aosewski deleted the aosewski/conv3d_example branch February 16, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@geyyer geyyer geyyer left review comments

@asroy asroy Awaiting requested review from asroy

+1 more reviewer

@zjing14 zjing14 zjing14 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@aosewski aosewski

Labels

CI - Pass

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aosewski @geyyer @zjing14 @asroy