Skip to content

add split-k GEMM #59

Merged
asroy merged 35 commits into
developfrom
conv_splitk_f32
Feb 3, 2022
Merged

add split-k GEMM #59
asroy merged 35 commits into
developfrom
conv_splitk_f32

Conversation

@ltqin
Copy link
Copy Markdown
Collaborator

@ltqin ltqin commented Nov 25, 2021

This PR add split-k GEMM, data type is fp32
ckProfiler command:
./profiler/ckProfiler gemm 0 0 1 1 0 5 1024 1024 1024 1024 1024 1024 10
The last parameter '10' means split k to 10 partition(batch)

test command:
./build/test/test_split_k 0 1024 1024 1024 1024 1024 1024 10

@ltqin ltqin requested review from asroy and zjing14 November 25, 2021 08:15
@asroy
Copy link
Copy Markdown
Contributor

asroy commented Nov 30, 2021

@ltqin Need a ctest like #58

Comment thread composable_kernel/include/utility/config.hpp Outdated
Comment thread device_operation/device_gemm_xdl_instance_f32_f32_f32_km_kn_mn.cpp Outdated
Comment thread device_operation/device_gemm_xdl_instance_f32_f32_f32_mk_nk_mn.cpp Outdated
@ltqin
Copy link
Copy Markdown
Collaborator Author

ltqin commented Dec 17, 2021

@asroy @zjing14 test is added, pls review again

zjing14
zjing14 previously approved these changes Jan 11, 2022
Copy link
Copy Markdown
Contributor

@zjing14 zjing14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjing14
Copy link
Copy Markdown
Contributor

zjing14 commented Jan 29, 2022

@asroy @ltqin fixed compiling issues.

Jing Zhang and others added 2 commits January 29, 2022 05:05
@asroy asroy self-requested a review February 3, 2022 04:46
@asroy asroy merged commit 4be7f01 into develop Feb 3, 2022
illsilin pushed a commit that referenced this pull request Apr 25, 2022
PR from ROCmSoftwarePlatform/composable_kernel
@junliume junliume deleted the conv_splitk_f32 branch October 21, 2023 06:09
carlushuang added a commit that referenced this pull request Jan 31, 2024
* WIP add generic masking

* now local is not correct

* fix bug in local atn

* support when a whole row is masked

* fix a bug in local attn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants