[Navi3x Bug Fix] fix typo to accept MNKPadding flag correctly.#597
Merged
Conversation
asroy
suggested changes
Feb 24, 2023
asroy
suggested changes
Feb 28, 2023
Contributor
asroy
left a comment
asroy
left a comment
There was a problem hiding this comment.
need cosmetic change, otherwise looks good
asroy
approved these changes
Mar 1, 2023
carlushuang
pushed a commit
that referenced
this pull request
Mar 6, 2023
* fix a bug blocking wmma_gemm_multipleD * Utilize matrix padder in device_wmma_op * cosmetic change for gemmpadding format * clang format * Change gridwise gemm from FIFO to KMN loop fashion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As stated in the title. This PR fix a blocking issue on AIT side.
cc. @Yanxing-Shi