Add gemm_shuffle host api#71
Merged
Merged
Conversation
added 2 commits
January 21, 2022 06:10
asroy
previously approved these changes
Jan 21, 2022
Contributor
|
@rocking5566 Need to do clang-format next time |
rosenrodt
reviewed
Jan 21, 2022
| MXdlPerWave, | ||
| NXdlPerWave, | ||
| ABlockTransferThreadClusterLengths_K0_M_K1, | ||
| Sequence<1, 0, 2>, // ABlockTransferThreadClusterArrangeOrder, |
Contributor
There was a problem hiding this comment.
@rocking5566 There shouldn't be hardcoded parameters here.
| } | ||
| else | ||
| { | ||
| const auto kernel = kernel_gemm_xdlops_v2r3< |
Contributor
There was a problem hiding this comment.
@rocking5566 Is v2r3 a typo here, since you were invoking v3r1 kernel when condition is true? @asroy can you confirm if this is intended?
carlushuang
added a commit
that referenced
this pull request
Jan 31, 2024
* compute correct * improve perf, but seems pipeline has duplicated ISA * refactor generate_kernel * remove duplicated GetBlockQKGemm * finialize a more generic codegen * refactor into autogen API * fix some comment * Use occupancy=1 for hdim=256 * support hdim=256 * modify some comment * we no longer need to change target inside a file * update bench script * add readme * modify --------- Co-authored-by: Po Yen, Chen <PoYen.Chen@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[What]
[Why] Prepare to add shuuffle version of D = alpha * (A * B) + beta * C
[How] Imitate DeviceGemmXdl and device_conv2d_fwd_xdl_c_shuffle_nhwc_kyxc_nhwk.hpp