Add class type support for __builtin_amdgcn_readfirstlane()#711
Merged
Conversation
Contributor
Author
|
It seems the offset calculation in |
asroy
reviewed
May 25, 2023
asroy
reviewed
May 25, 2023
asroy
reviewed
May 25, 2023
Contributor
Author
|
I mode following changes
|
asroy
reviewed
May 30, 2023
| template < | ||
| typename Object, | ||
| typename = std::enable_if_t<std::is_class_v<Object> && std::is_trivially_copyable_v<Object>>> | ||
| __device__ auto readfirstlane(const Object& obj) |
Contributor
There was a problem hiding this comment.
This is a AMD specific function, not standard HIP. I think better rename to "amd_wave_read_first_lane", similar to "amd_buffer_load"
asroy
suggested changes
May 30, 2023
Contributor
asroy
left a comment
asroy
left a comment
There was a problem hiding this comment.
Please rename function from to "amd_xxx", maybe "amd_wave_read_first_lane". Otherwise LGTM
Contributor
Author
Done. I also renamed the header file. |
asroy
approved these changes
May 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR added
ck::amd_wave_read_first_lane()overloaded functions to unify call syntax of__builtin_amdgcn_readfirstlane().The
ck::amd_wave_read_first_lane()supportsstd::int32_t& trivially copyable object arguments.