support dynamic buffer using memory coherence glc_slc bit from template#725
Merged
Conversation
qianfengz
previously approved these changes
May 26, 2023
asroy
suggested changes
May 30, 2023
qianfengz
reviewed
May 31, 2023
Contributor
qianfengz
left a comment
qianfengz
left a comment
There was a problem hiding this comment.
The latest change works with my BatchNorm split-K testing example
aosewski
reviewed
May 31, 2023
Comment on lines
+296
to
+299
| DefaultCoherence = 0, // default value | ||
| GLC = 1, | ||
| SLC = 2, | ||
| GLC_SLC = 3, |
Collaborator
There was a problem hiding this comment.
I think it would be nice to have here explanation of what behavior to expect from each enumerator value. In the mentioned document the page 58 explains also the SLC bit.
Contributor
Author
There was a problem hiding this comment.
Hi @aosewski , the problem is, different architecture may have different meanings, so I still suggest we have the name only
asroy
approved these changes
May 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
amd_buffer_coherence_bitsenum to switch between different coherence bits in buffer load/store.DynamicBufferthrough template arg (so we no need to change every threadwise copy)make_dynamic_buffer()functionamd_buffer_coherence_bits::default_coherenceThe change in this P.R has been used and verified by
gridwise_multiblock_batchnorm_forward_generic.hpp