Using number of compute units to set gridSize#754
Merged
Conversation
rocking5566
reviewed
Jun 13, 2023
| return (count); | ||
| }; | ||
|
|
||
| hip_check_error(hipExtStreamGetCUMask(stream_config.stream_id_, MAX_MASK_DWORDS, &cuMask[0])); |
Collaborator
There was a problem hiding this comment.
Why not just getting the multiProcessorCount property from the device ? https://docs.amd.com/bundle/HIP-API-Guide-v5.4.1/page/a01151.html#add8d9d2ad52aece9fd1dbe25c18d9d57
Contributor
Author
There was a problem hiding this comment.
Why not just getting the
multiProcessorCountproperty from the device ? https://docs.amd.com/bundle/HIP-API-Guide-v5.4.1/page/a01151.html#add8d9d2ad52aece9fd1dbe25c18d9d57
Cause the CUs usable by a stream can be masked by the hipExtStreamCreateWithCUMask(), multiple streams can be created on the same device, we should concern about the stream, rather the device.
rocking5566
approved these changes
Jun 14, 2023
hyoon1
pushed a commit
to hyoon1/composable_kernel
that referenced
this pull request
Mar 19, 2026
…m#754) * Add split-k, M<->H to varseq path * skip M<->H when dropout>0, fix LSE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix to Issue 266