Update test CMakeLists to add new tests automatically and add Jenkins stage for tests#88
Merged
Conversation
reorg test dir add test stage
JehandadKhan
commented
Feb 16, 2022
JehandadKhan
commented
Feb 16, 2022
JehandadKhan
commented
Feb 16, 2022
Contributor
Author
|
@asroy Please note that the newly added test fails when run on certain machines |
asroy
previously approved these changes
Feb 19, 2022
Contributor
|
I cannot find reproduce the test_conv2d_fwd failure on ROCm4.3. Maybe this is a compiler issue. Can we change the CI docker to ROCm4.3? |
Contributor
|
Updated the Dockerfile to use rocm4.3.1 Jekins failed: |
Contributor
Author
|
@asroy CI passes |
asroy
approved these changes
Mar 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR depends on #86
The test needs to be a single cpp file with its own main function.