Allow distinct K0/K1 values for A/B block descriptor#98
Merged
Conversation
- remove dangling header include - modify example gemm_xdl accordingly - infer KPack value from M/NPerXdl - device conv2d fwd: update parameters accordingly for the underlying gridwise gemm v3r1 (API for conv2d fwd stays the same for now until we decide to expose individual K0s for activation and weight)
asroy
reviewed
Feb 24, 2022
asroy
reviewed
Feb 24, 2022
asroy
reviewed
Feb 25, 2022
Contributor
|
Please use clang-format-10 in future PR |
asroy
approved these changes
Feb 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GridwiseGemm_k0mk1_k0nk1_mn_xdlops_v3r1template parameter change:DeviceGemmXdl_C_Shufflekernel instancesNext action
DeviceGemmXdl_C_Shufflekernel instancesTest script reports all error = 0
Performance data on MI100 at 1087mhz