fix: do not create cdi object in runtime#102
Merged
sgopinath1 merged 1 commit intoROCm:mainfrom Feb 20, 2026
Merged
Conversation
Signed-off-by: Shiv Tyagi <Shiv.Tyagi@amd.com>
shiv-tyagi
changed the title
sgopinath1
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes cdi object creation on container start.
Motivation
The shim (amd-container-runtime) shouldn't create a CDI object each run. We are not using it anywhere.
In addition, the runtime no longer fails entirely when it lacks access or permissions to the CDI spec directory.
Technical Details
Removed CDI initialization and the
cdifield fromruntime.New()inruntime.go(no remaining uses ofrt.cdiin the codebase).Test Plan
Tested the runtime binary on a GPU setup to verify behavior is unchanged.
Test Result
The runtime works correctly after these changes.
Submission Checklist