fix(rccl): skip sudo-only checks without passwordless sudo#140
Merged
Conversation
Add cluster-wide sudo -n probe; skip firewall/dmesg/snapshot steps when unavailable. Drop sudo from RCCL hostfile cleanup on the head node. Made-with: Cursor
cijohnson
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_passwordless_sudo_status()to probesudo -nacross nodes.cluster_snapshot_debugsnapshots when passwordless sudo is not available on all nodes.rccl_lib: remove unnecessarysudofrom head-node hostfile cleanup (rmof/tmp/rccl_hosts_file.txt).Test plan
python -m compileallon touched modulespytest cvs/lib/unittests/test_utils_lib.py(with required--cluster_file/--config_fileargs)Made with Cursor