Skip to content

Remove the hacky semaphore override for libhipcxx #21

@jamesETsmith

Description

@jamesETsmith

🔨Work Item

There was a change to how libhipcxx last year that explicitly disallows use of semaphore (see my issue ROCm/libhipcxx#10). Since we want to work with the latest version of libhipcxx, we're forced to do some very hacky and brittle things when installing dependencies for graphbolt, see the discussion here: #16.

# TODO this is an unacceptable way to do this,
# see https://github.com/ROCm/libhipcxx/issues/10 for more details
# This was implicitly not allowed in previous releases we were using,
# but with v2.7.0 they are explicitly not allowed.
# We only use semaphores for a counter of IO operations in graphbolt,
# that only runs on the host (not on the device) so we should be "safe"
# to use this for now.
sed -i '/#error semaphore is not supported on AMD hardware and should not be included/d' ${INSTALL_PREFIX}/include/rapids/libhipcxx/cuda/semaphore
sed -i '/#error semaphore is not supported on AMD hardware and should not be included/d' ${INSTALL_PREFIX}/include/rapids/libhipcxx/hip/semaphore
sed -i '/#error semaphore is not supported on AMD hardware and should not be included/d' ${INSTALL_PREFIX}/include/rapids/libhipcxx/cuda/std/semaphore
sed -i '/#error semaphore is not supported on AMD hardware and should not be included/d' ${INSTALL_PREFIX}/include/rapids/libhipcxx/hip/std/semaphore

We'd like to get rid of this as soon as possible.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions