[CP 1210] GPUOP-588 filter out workflow related pods from drain step#479
Merged
sajmera-pensando merged 1 commit intoROCm:mainfrom Mar 24, 2026
Conversation
* GPUOP-588 ignore workflow pods during drain * more validations for configmap (cherry picked from commit 554ddd5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cp of pensando/gpu-operator#1210
This PR improves remediation workflow behavior by (1) excluding remediation workflow pods from the drain step, (2) adding validation for user-supplied remediation workflow ConfigMaps, and (3) adjusting recovery-policy window handling when syncing internal state from the status CR.
Changes:
Add validateUserConfigMap and call it before creating/loading remediation default objects.
Pass workflow mappings into syncInternalMapFromStatusCR to apply per-condition recovery-policy window filtering.
Update drain.sh jq selection to ignore pods belonging to the remediation workflow controller instance.