test(e2e): chunked suite, pretty report, teardown hardening, driver-load capture#559
Merged
Merged
Conversation
…oad capture
Cherry-pick of f210673a, excluding docs-internal/superpowers/** (added
docs-internal/* to .gitignore to match the ci-internal/tools-internal
pattern — planning/design docs are developer-local, not repo artifacts).
Changes from original commit:
- Chunked Makefile: auto-discovered chunks via *_test.go glob, numeric
prefix for ordering (01_cluster_core, 02_cluster_upgrade_policy), single
CHUNK_TIMEOUT via -test.timeout=45m, dropped per-chunk timeout map.
- Split cluster_test.go (3347 lines) into four files:
01_cluster_core_test.go (14 driver-install tests, *DriverInstallSuite)
02_cluster_upgrade_policy_test.go (15 upgrade tests, *DriverInstallSuite)
cluster_rbac_test.go ( 7 RBAC + SM tests, *E2ESuite)
cluster_helpers_test.go (41 helpers + const block, *E2ESuite)
- New driver_install_suite_test.go: DriverInstallSuite wraps E2ESuite with
wipeDriverState pre/post step for clean cluster across driver-install chunks.
- TearDownTest/Suite Fatalf -> Errorf+continue to preserve cleanup on failure.
- TestMonitor: CaptureRunnerBaseline (SetUpSuite) + CaptureDriverState
(TearDownTest on c.Failed); leafTestName() helper normalizes suite-prefixed
test names; unit tests cover both E2ESuite.* and DriverInstallSuite.* paths.
- New chunk_report.py: Python stdlib chunk-report renderer (ANSI + plain
mirror, discovery-based, UTF-8 encoding); test_chunk_report.py uses inline
fixtures via textwrap.dedent (no fixture files), 11/11 unit tests pass.
- Renamed dcm_e2e_test.go -> dcm_test.go, dra_driver_test.go -> dra_test.go.
- .markdownlint-cli2.jsonc: add **/docs-internal/** to ignore list.
Co-Authored-By: Claude Sonnet 4 (1M context) <noreply@anthropic.com>
spraveenio
requested review from
biluriuday,
sajmera-pensando,
shiv-tyagi and
yansun1996
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cp of https://github.com/pensando/gpu-operator/pull/1468
What changed
Makefile — auto-discovered chunks
*_test.gofilenames, no catalog to maintain01_cluster_core,02_cluster_upgrade_policyrun first-test.timeout=45mflag; override viaTEST_ARGSTest file split (
cluster_test.go→ 4 files)01_cluster_core_test.goDriverInstallSuite02_cluster_upgrade_policy_test.goDriverInstallSuitecluster_rbac_test.goE2ESuitecluster_helpers_test.goE2ESuiteNew:
DriverInstallSuite— wrapsE2ESuitewithwipeDriverStatepre/post so driver-install chunks start on a clean cluster.Teardown hardening —
Fatalf→Errorf+continueso cleanup runs even on failure.TestMonitor
CaptureRunnerBaselineatSetUpSuite;CaptureDriverStateatTearDownTeston failureleafTestName()normalizesE2ESuite.TestX→TestXfor the rendererchunk_report.py— Python stdlib chunk-report renderer; ANSI + plain mirror; UTF-8 safe. Tests synthesize fixtures inline (no fixture files), 11/11 pass.Renames —
dcm_e2e_test.go→dcm_test.go,dra_driver_test.go→dra_test.go.gitignore
Added
docs-internal/*— matches existingci-internal/*/tools-internal/*pattern; planning docs are developer-local artifacts.🤖 Generated with Claude Code