cleanup and clarification of unified/managed memory docs#3819
Closed
briankoco wants to merge 0 commit intodocs/developfrom
Closed
cleanup and clarification of unified/managed memory docs#3819briankoco wants to merge 0 commit intodocs/developfrom
briankoco wants to merge 0 commit intodocs/developfrom
Conversation
12 tasks
Contributor
|
LGTM, I don't have access to approving PRs here. I've invited @randyh62 to also take a look |
randyh62
approved these changes
Jul 15, 2025
randyh62
reviewed
Jul 16, 2025
randyh62
approved these changes
Jul 16, 2025
Contributor
|
@briankoco Is there a reason why this was closed instead of it being merged in? Should we prepare a PR from our side with your changes? |
Member
Author
|
I believe the changes have been merged. Github was not allowing me to merge, with an error about the branch being unable to rebase due to conflicts. I followed the command line approach of checking out |
Contributor
|
Ah okay, I see the commits in docs/develop now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated JIRA ticket number/Github issue number
N/A
What type of PR is this? (check all applicable)
What were the changes?
hipHostRegister()managed memory table entriesWhy are these changes needed?
Some of the unified memory documentation is incorrect, and performance implications of managed memory were not sufficiently captured
Updated CHANGELOG?
Added/Updated documentation?
Additional Checks