Skip to content

Clean up util directory #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
derobins merged 3 commits into from
Nov 18, 2025
Merged

Clean up util directory #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
48ed1a6
Add quoting from shellcheck
derobins Nov 18, 2025
243369c
Tidy README.md
derobins Nov 18, 2025
4c7cfda
Clean up unused scripts in `util`
derobins Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions util/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,14 @@
# [INTERNAL] AIS Development Utilities
# hipFile Development Utilities

## clear-journal.sh
## files-changed.sh

Clears systemd's journal.
Determines if important files changed. Used by CI.

## format-source.sh

Formats applicable source in the repo using a specific version
of `clang-format`. Run it from the root.

## llvm-coverage.sh

Code coverage script used by CI.
Copy link

Copilot AI Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README.md documents all shell scripts but doesn't mention the docker/ subdirectory which contains three DOCKERFILE files (ais_ci_rocky, ais_ci_suse, ais_ci_ubuntu). Consider adding a section documenting the docker subdirectory and its purpose for completeness.

Example:

## docker/

Contains Dockerfiles for CI environments on different Linux distributions (Rocky, SUSE, Ubuntu).
Suggested change
Code coverage script used by CI.
Code coverage script used by CI.
## docker/
Contains Dockerfiles for CI environments on different Linux distributions (Rocky, SUSE, Ubuntu).

Copilot uses AI. Check for mistakes.
12 changes: 0 additions & 12 deletions util/clear-journal.sh
View file
Open in desktop

This file was deleted.

8 changes: 4 additions & 4 deletions util/files-changed.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,17 +16,17 @@ CHECK_PATTERN=$3
FILES_CHANGED=0

changed_files=()
if ! diff_output="$(git diff --name-only ${BASE_REF} ${HEAD_REF})"; then
echo ${diff_output}
if ! diff_output="$(git diff --name-only "${BASE_REF}" "${HEAD_REF}")"; then
echo "${diff_output}"
exit 1
fi
mapfile -t changed_files <<< "${diff_output}"

for changed_file in "${changed_files[@]}"; do
if [[ "${changed_file}" == ${CHECK_PATTERN} ]]; then
if [[ "${changed_file}" == "${CHECK_PATTERN}" ]]; then
FILES_CHANGED=1
fi
done

printf '%s' ${FILES_CHANGED}
Copy link

Copilot AI Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable ${FILES_CHANGED} should be quoted as \"${FILES_CHANGED}\" to be consistent with the PR's shellcheck quoting improvements, even though it contains only numeric values.

Suggested change
printf '%s' ${FILES_CHANGED}
printf '%s' "${FILES_CHANGED}"

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable FILES_CHANGED should be quoted here to follow the same shellcheck improvements applied to other variables in this file. This ensures consistent behavior when the variable is empty or contains special characters.

Suggested change:

printf '%s' "${FILES_CHANGED}"
Suggested change
printf '%s' ${FILES_CHANGED}
printf '%s' "${FILES_CHANGED}"

Copilot uses AI. Check for mistakes.
exit 0
exit 0
30 changes: 0 additions & 30 deletions util/full-clang-lint.sh
View file
Open in desktop

This file was deleted.

116 changes: 0 additions & 116 deletions util/iterate-fio-jobs.sh
View file
Open in desktop

This file was deleted.

Loading
Loading