Skip to content

Fix cmake-lint problems#65

Merged
derobins merged 3 commits into
developfrom
derobins/cmake-lint
Nov 19, 2025
Merged

Fix cmake-lint problems#65
derobins merged 3 commits into
developfrom
derobins/cmake-lint

Conversation

@derobins
Copy link
Copy Markdown
Collaborator

  • Add an rc file for running cmake-lint
    • Currently just suppresses line length warnings
  • Fix identified issues
  • Add suppression comments for FetchContent format issues

Does not fix the FetchContent naming complaints as those
are not something we control
The CMake linter does not like FooBar_BazWhat.
Copilot AI review requested due to automatic review settings November 19, 2025 01:38
@derobins
Copy link
Copy Markdown
Collaborator Author

The repo will be cmake-lint clean with these changes. When this goes in, I'll add a CI job to ensure it stays clean.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request addresses cmake-lint warnings across the CMake build system by establishing linting standards and fixing identified issues. The changes ensure consistent code formatting and style compliance with cmake-lint rules while allowing exceptions for third-party FetchContent commands.

  • Added .cmakelintrc configuration file to suppress line length warnings
  • Fixed formatting issues including trailing whitespace, function declaration spacing, command casing, and indentation
  • Added lint suppression comments for FetchContent blocks with mixed-case commands

Reviewed Changes

Copilot reviewed 4 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
.cmakelintrc New configuration file that suppresses line length warnings for cmake-lint
rocfile/src/CMakeLists.txt Removed trailing whitespace after SYSINCLS parameter
cmake/AISUseROCmCMake.cmake Added lint suppression comments around FetchContent_Declare/MakeAvailable blocks
cmake/AISUseGTest.cmake Added lint suppression comments, blank line for readability, and fixed function declaration spacing
cmake/AISSetCoverageFile.cmake Fixed function declaration spacing and changed MATH to lowercase math
cmake/AISSanitizers.cmake Fixed function declaration spacing by removing space before parenthesis
cmake/AISInstall.cmake Fixed indentation for rocm_install call to align with surrounding code
cmake/AISGNUCompilerOptions.cmake Removed trailing whitespace after set(flags declaration
cmake/AISCompilerOptions.cmake Fixed function declaration spacing by removing space before parenthesis

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@derobins derobins mentioned this pull request Nov 19, 2025
@derobins derobins merged commit b1be6d9 into develop Nov 19, 2025
37 checks passed
@derobins derobins deleted the derobins/cmake-lint branch November 19, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants